[systemd-devel] [PATCH v2 0/7] logind: close races on user and session states

Djalal Harouni tixxdz at opendz.org
Fri Feb 7 11:24:31 PST 2014

On Fri, Feb 07, 2014 at 04:29:48PM +0100, Lennart Poettering wrote:
> On Thu, 06.02.14 21:37, Djalal Harouni (tixxdz at opendz.org) wrote:
> Heya!
> So, I was working on fixes for this in parallel which I have pushed
> earlier today, which change a couple of things around in more complex
> ways. Some of them conflict with yours changes. I'll commit the
> ones of yours that still appear necessary. If you think I am missing
> some, please let me know.
Ok, I'll do.

> The new logic I commited changes around how scopes are used by
> logind. Previously the KillUserProcesses= option in logind.conf would
> influence KillMode= of the scope. However that was a bad idea since we
> actually want to provide people a way to terminate sessions and we
> actually need them to order things properly on shutdown so that scopes
> go away before the network is removed, and suchlike. Hence I changed the
Yes, I was going to ask about why scopes are influenced by
KillUserProcesses? anyway I'll read your changes.

> logic so we are OK with leavig scopes around from the logind side, we
> just mark the session entries as "closing". KillUserProcesses= hence
> simply controls whether we leave them around and hence the session in
> "closing" or whether we actively shut them down.

> Sorry for commiting into the middle of your work!
No worries, I did a dive into the internals and the picture is still not
clear :-)

> Lennart

> -- 
> Lennart Poettering, Red Hat

Djalal Harouni

More information about the systemd-devel mailing list