[systemd-devel] [PATCH] pager: remove --no-init setting from LESS options

[Lennart Poettering]

On Tue, 11.02.14 10:09, Andrey Borzenkov (arvidjaar at gmail.com) wrote:

> On Tue, Feb 11, 2014 at 9:15 AM, Mantas Mikulėnas <grawity at gmail.com> wrote:
> > On Feb 11, 2014 7:02 AM, "Jason A. Donenfeld" <Jason at zx2c4.com> wrote:
> >>
> >> I use konsole. It has a nice feature that when the scrollbars have been
> >> disabled -- like in the case of a full-console app like vim or less --
> >> it makes the mouse wheel send up and down key strokes, so that
> >> scrolling happens. It's really nice. I open up less, and then I can
> >> scroll through it using the mouse wheel.
> >>
> >> This doesn't work with systemd's pager, however, because systemd passes
> >> --no-init to less. This patch removes this "X" flag.
> >
> > On the one hand, scrolling like that is convenient, in gnome-terminal as
> > well – on the other hand, removing -X causes `less` open the "alt screen"
> > mode even for really short outputs, which can become annoying quickly…
> >
> 
> Should not it simply respect existing LESS value? Or, for that matter,
> SYSTEMD_LESS if someone thinks of a good reason to have different
> settings?

I think adding support for $SYSTEMD_LESS which is copied to $LESS right
before invoking less would be a good choice, since it would allow people
to override whatever systemd tries to set.

I'd be happy to merge a patch for this.

Lennart

-- 
Lennart Poettering, Red Hat