[systemd-devel] [PATCH] core/service: check if mainpid matches only if it set

[Lennart Poettering]

On Fri, 14.02.14 10:15, Tomasz Torcz (tomek at pipebreaker.pl) wrote:

> On Mon, Dec 30, 2013 at 05:26:19PM +0100, Zbigniew Jędrzejewski-Szmek wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1047304
> >  
> > -        if (s->notify_access == NOTIFY_MAIN && pid != s->main_pid) {
> > +        if (s->notify_access == NOTIFY_MAIN && s->main_pid != 0 && pid != s->main_pid) {
> 
>   I don't think this patch is correct.  It only papers over real issue. The
> real problem is that systemd sometimes "loses state" during reload/reexec.
> Colin found the problem in "[systemd-devel] daemon-reload seems racy".

At the hackfest in Brussels Colin debugged this and found out that this
is caused by a patch that is not upstream.

Lennart

-- 
Lennart Poettering, Red Hat