[systemd-devel] [PATCH 1/2] udev: use "bit" as unit for network card speeds

[Tom Gundersen]

On Wed, Nov 13, 2013 at 3:58 AM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Tue, 12.11.13 05:49, Jan Engelhardt (jengelh at inai.de) wrote:
>
>> Given a card that can do 100 Mbit/s, that would be about 12.5 MByte/s,
>> but you cannot seriously expect me to use that value. Although it is
>> quite compelling for 40 Gbit/s because that divides nicely to 5
>> GByte/sec, and we will be seeing increasing speeds :)
>
> Hmm, so, for the byte options we actually used a syntax where the unit
> factor was included in the value, not the key. For example, in
> journald.conf you can write SystemMaxUse=100M to express that 100MBytes
> at max are used for system journals.
>
> I am not entirely sure what this means for the network configuration
> bits.
>
> Maybe "BitsPerSecond=100M" to indicate 100MBit? It might be nicer to
> allow this given that there are Gigabit links too ("BitsPerSecond=4G")
> and (at least in theory) much slower links too ("BitsPerSecond=28800").

Sorry for dropping the ball on this. This suggestion has now been
committed as <http://cgit.freedesktop.org/systemd/systemd/commit/?id=733f7a2c69c794a81978a08a79916c224ba355a6>.

Cheers,

Tom