[systemd-devel] [PATCH v2] rtnl: fix memory corruptions after realloc

Tom Gundersen teg at jklm.no
Wed Jan 1 03:21:28 PST 2014


On Wed, Jan 1, 2014 at 2:18 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> struct sd_rtnl_message would keep two additional pointers into the hdr
> field. Every time hdr was realloced, those pointers should be adjusted,
> but weren't.

Or rather, only one of the two were adjusted, right?

> It seems less error-prone to keep offsets instead.

I agree, feel free to push if it works for you (your patch didn't
apply here due to whitespace problems...).

Cheers,

Tom


More information about the systemd-devel mailing list