[systemd-devel] [PATCH] journal: Add missing byte order conversions

[Zbigniew Jędrzejewski-Szmek]

On Tue, Dec 31, 2013 at 02:37:32PM -0600, George McCollister wrote:
> Convert entry_array.items[0] to host byte order prior to passing it to
> chain_cache_put().
Applied.

> Signed-off-by: George McCollister <george.mccollister at gmail.com>
No need for this.

> --- a/src/journal/journal-file.c
> +++ b/src/journal/journal-file.c
> @@ -1452,7 +1452,7 @@ static int generic_array_get(
>  
>  found:
>          /* Let's cache this item for the next invocation */
> -        chain_cache_put(f->chain_cache, ci, first, a, o->entry_array.items[0], t, i);
> +        chain_cache_put(f->chain_cache, ci, first, a, le64toh(o->entry_array.items[0]), t, i);
I applied the same treatment to journal-verify.c. Can you check how
journalctl --verify behaves for you?

Zbyszek