[systemd-devel] [PATCH] gpt-auto-generator: skip nonexistent devices

[Zbigniew Jędrzejewski-Szmek]

On Tue, Jan 07, 2014 at 03:00:22PM +0100, Łukasz Stelmach wrote:
> Hi,
> 
> The devices we work with have eMMC chips for storage. The chips
> provide four "hardware" partitions.  The first is /dev/mmcblk0, it
> takes almost whole space and holds a GPT with several real partitions
> (/dev/mmcblk0p?). Then there are three block devices (mmcblk0boot0,
> mmcblk0boot1, rpmb) that are part of the same hardware as mmcblk0 that
> are presented by the kernel as children of the latter. That relationship
> makes gpt-auto-generator try to peek them but since they are not GPT
> partitions blkid_do_safeprobe() returns -2 making verify_gpt_parition()
> function return -ENODEV.
Applied, after fixing to work with current git :)

> I am not sure both -1 and -2 returned by blkid_do_safeprobe() should
> result in -ENODEV in verify_gpt_parition(), however, -ENODEV does not
> mean IMHO we should stop iterating udev results in enumerate_partitions().
It's +1 and -2, which have the same meaning for us. I changed this to
EBADSLT because ENODEV is misleading.

> Signed-off-by: Łukasz Stelmach <l.stelmach at samsung.com>
No need for that.

Zbyszek