[systemd-devel] [PATCH v2 6/8] add GOP mode setting and splash drawing support

[Tom Gundersen]

Hi Mikko,

On Fri, Jan 17, 2014 at 12:18 PM, Ylinen, Mikko <mikko.ylinen at intel.com> wrote:
> On Thu, Jan 16, 2014 at 5:21 PM, Tom Gundersen <teg at jklm.no> wrote:
>> Could we first try to optimize the BMP loader? Also, could you share
>> your test image so I can have a look?
>
> We've simply used the web page logo [1] exported using Gimp:
>
> $ identify gummiboot-icon3.bmp
> gummiboot-icon3.bmp BMP 295x245 295x245+0+0 8-bit DirectClass 218KB 0.000u
> 0:00.000

Thanks. I had another look at our BMP loader, and there are definite
room for improvement (e.g., pull out the case statement from our inner
loop).

I also discussed this with Kay a bit, and we agree that we don't want
to support some custom binary image format (unless we really, really
must). I think it should be possible to encode your format as BMP
though, by simply using the color bitmasks in the more recent versions
of the format. We could then special case the particular bitmasks that
correspond to BGRX and skip the loop. Does that sound like something
you could work with?

Cheers,

Tom