[systemd-devel] systemctl [en|dis]able weirdness + reload (writes /run/nologin)

[Lennart Poettering]

On Mon, 13.01.14 11:16, Colin Guthrie (gmane at colin.guthr.ie) wrote:

> Hi,
> 
> I've just been debugging a weird problem in my 208 build (which is quite
> similar to Fedora's - a lot of the same patches).
> 
> So far I've noticed two problems:
> 
> 
> 1. If I do "systemctl enable sysvinitscript" it will print me a warning
> about how the units do not carry [Install] sections. This is
> unsurprising as there are no units (the systemctl.c mangled_names - or
> just names in git master) left after the enable_sysv_units() method is
> called and the first item is a pointer to a null string. I suspect
> various bus calls could just be harmlessly skipped if this is the case
> (i.e. just don't do the various unit related method calls) as we know
> they are handled locally.
> 
> I've attached two patches which should solve this (one for 208+patches
> and one for git master aka 209) although I've not tested either
> directly. Some other eyes on it as to whether it's the correct approach
> or not would be appreciated. The only difference between the two
> versions is a variable name change.

For this issue I applied a different patch to git now. Can you check
pls?

(The patch simply skips all of the native enabling if the list is empty,
including the reload, under the assumption that chkconfig will care for
that on its own...) 

Lennart

-- 
Lennart Poettering, Red Hat