[systemd-devel] [PATCH 1/2] build-sys: merge libsystemd-login into libsystemd

[Lennart Poettering]

On Mon, 20.01.14 17:42, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> 
> On Mon, Jan 20, 2014 at 01:14:02PM +0100, Lennart Poettering wrote:
> > On Sun, 19.01.14 14:51, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
> > 
> > > So, I prepared a test patch. This all doesn't seem to be too ugly generally,
> > > although the warning generation in patch 2 is a bit.
> > > 
> > > Comments?
> > > 
> > > A compatibility libsystemd-login library is created which uses
> > > .symver and ifunc magic proposed by Lennart to make programs linked
> > > to the old library name continue to work seamlessly.
> > > 
> > > Unfortunately the bfd linker crashes:
> > >   https://sourceware.org/bugzilla/show_bug.cgi?id=16467
> > > As a work-around, gold can be used:
> > >   LDFLAGS=-Wl,-fuse-ld=gold
> > > 
> > > This also doesn't work with LLVM:
> > >   http://llvm.org/bugs/show_bug.cgi?id=11897
> > 
> > Looks good to me. That bfd chokes on this is a bummer though... But as
> > long as the bfd fix is backportable it sounds totally OK to me to still
> > do this.
> The bfs fix is backportable, and was proposed for the stable branch too.
> 
> Anyway, I don't see why using gold would be bad.

Good question. I have no experience with gold, but it's commonly
available these days, right? maybe we should just default to gold anyway
after detection in configur.ac?

Lennart

-- 
Lennart Poettering, Red Hat