[systemd-devel] [PATCH v2 6/8] add GOP mode setting and splash drawing support

[Tom Gundersen]

Hi Mikko,

On Wed, Jan 22, 2014 at 12:42 PM, Ylinen, Mikko <mikko.ylinen at intel.com> wrote:
>
> On Sun, Jan 19, 2014 at 5:59 AM, Kay Sievers <kay at vrfy.org> wrote:
>>
>> On Fri, Jan 17, 2014 at 12:18 PM, Ylinen, Mikko <mikko.ylinen at intel.com>
>> wrote:
>>
>> >> Could we first try to optimize the BMP loader? Also, could you share
>> >> your test image so I can have a look?
>> >
>> >
>> > We've simply used the web page logo [1] exported using Gimp:
>> >
>> > $ identify gummiboot-icon3.bmp
>> > gummiboot-icon3.bmp BMP 295x245 295x245+0+0 8-bit DirectClass 218KB
>> > 0.000u
>> > 0:00.000
>>
>> Unfortunately that doesn't say much. What color-depth is it? Do you
>> also use an alpha channel?
>>
>> Gimp automatically imports the alpha channel from the SVG background
>> layer. With alpha, it is the slowest of the options we have, we have
>> to calculate every byte by merging the original with the pict and
>> store it back.
>>
>> This is the one in the gummiboot git tree:
>>   $ identify test/splash.bmp
>>   test/splash.bmp BMP 295x245 295x245+0+0 8-bit sRGB 289KB 0.000u 0:00.000
>> It's 32bit/pixel, with an alpha channel.
>>
>> It's a bit larger, your pict is 24 bit?
>
>
> I verified the numbers and used test/splash.bmp as the source image.
> Looks like test/splash.bmp only adds 10ms more compared with BGRX.
>
> My original BMP is 24bit, no alpha. As far as I can tell this is the same
> as test/splash.bmp but without alpha channel.

Hm, so are you saying that the 24bit BMP adds 75ms, but the 32bit one
only adds 15ms in your measurements (compared to no splash at all)?
That would be very odd...

(FWIW, I'm also seeing ~10-20ms for 32 bit BMP (which I thought was
reasonable)).

-t