[systemd-devel] merging libsd-id128 and libsd-login with libsystemd

[Lennart Poettering]

On Sun, 26.01.14 00:16, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> On Thu, Jan 16, 2014 at 04:41:48PM +0100, Lennart Poettering wrote:
> > So I am pretty sure libsystemd-id128, libsystemd-login,
> > libsystemd-journal should just end up in a single libsystemd.so together
> > with the event loop, the bus, the asyncns stuff and more. All this
> > functinality requires each other, and should nto pull in its own copy of
> > src/shared/*.c each time.
> I now pushed a series of patches which merge libsystemd-id128 and
> libsystemd-login into libsystemd. I also changed the linker to gold by
> default, becuase bfd had a bug [1]. It has since been fixed, but not
> released yet, and anyway gold is minimally faster. When running distcheck,
> which uses -flto, a bug [2] in gold was uncovered. I worked
> around it by disabling lto for the compat libsystemd-login. I doesn't
> matter much anyway for this lib. All in all, this doesn't give a good feeling...
> I wouldn't be surprised if other issues pop up. I guess it's better to
> do this now and potentially revert than right before release.
> 
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=16467
> [2] https://sourceware.org/bugzilla/show_bug.cgi?id=16504
> 
> libsystemd-journal is more complicated. It uses libsystemd-label, which
> in turn uses libselinux. Doing a straighforward merge would mean that
> everything is linked with libselinux. I think that the idea of splitting
> the reporting side of sd-journal and moving it to libsystemd, while
> keeping the rest separate, might be a good idea. Comments?

Hmm, any idea what precisely the label calls are we make in
libsystemd-journal? Given that this is a client-side library it appears
surprising that it needs to check the selinux database for
something. Maybe we can change this to just not use the label-version of
the respective calls?

Lennart

-- 
Lennart Poettering, Red Hat