[systemd-devel] [RFC PATCH 1/2] Replace mkostemp+unlink with open(O_TMPFILE)

[Kay Sievers]

On Mon, Jan 27, 2014 at 5:35 PM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Mon, Jan 27, 2014 at 03:14:28PM +0100, Lennart Poettering wrote:
>> Yupp, it's certainly a good idea to make our logging functions safe for
>> execution in any context.
>>
>> What I don't understands though is why mkostemp() would not be safe here?
> mkostemp is not on the list of "safe" functions. I looked at the
> implementation, and it actually has a static variable, so it really
> cannot be called.

But does this matter here? The static var is still mixed with random.
It seems it will work just fine, at least with the next iteration?

Kay