[systemd-devel] [PATCH] sysusers: fix uninitialized warning

Ronny Chevalier chevalier.ronny at gmail.com
Sun Jul 6 05:14:28 PDT 2014


2014-07-06 14:06 GMT+02:00 Tom Gundersen <teg at jklm.no>:
> On Sun, Jul 6, 2014 at 1:33 PM, Ronny Chevalier
> <chevalier.ronny at gmail.com> wrote:
>> ---
>>  src/sysusers/sysusers.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c
>> index 1209a5a..c0af693 100644
>> --- a/src/sysusers/sysusers.c
>> +++ b/src/sysusers/sysusers.c
>> @@ -1312,6 +1312,8 @@ static int parse_line(const char *fname, unsigned line, const char *buffer) {
>>
>>                  h = groups;
>>                  break;
>> +        default:
>> +                return -EBADMSG;
>>          }
>
> Hm, this code-path should never happen, right? Is your compiler complaining?
>
> -t
Yes because it doesn't know that the IN_SET forbid this. So it just
fix the warning.

>
>>          i->type = action[0];
>> --
>> 2.0.1
>>
>> _______________________________________________
>> systemd-devel mailing list
>> systemd-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


More information about the systemd-devel mailing list