[systemd-devel] [PATCH 1/2] journal: add LZ4 as optional compressor

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Sun Jul 6 06:26:30 PDT 2014


On Sun, Jul 06, 2014 at 02:57:17PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Sun, Jul 06, 2014 at 01:05:29PM +0200, Ronny Chevalier wrote:
> > 2014-07-05 20:56 GMT+02:00 Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>:
> > > +        if (src_size < 9)
> > > +                return -ENOSPC;
> > Also, I am not sure that ENOSPC is appropriate here (and everywhere) ?
> > Why not ENOMEM (since there is no devices involved) ?
> Goood idea.
Actually ENOMEM is used for failed allocations, which we need to distinguish.
So it's either E2BIG or ENOSPC. Neither is too good.

> Thanks for all the comments, I will fix them before next submission.

Zbyszek


More information about the systemd-devel mailing list