[systemd-devel] [PATCH] systemd-detect-s390-virt: add virtualization detection on s390x

[Thomas Blume]

On Fri, 4 Jul 2014, Dan Horák wrote:

> On Fri, 4 Jul 2014 15:07:18 +0200 (CEST)
> Thomas Blume <Thomas.Blume at suse.com> wrote:
>
>> systemd was lacking the code to detect virtualization on s390x.
>> The patch adds detection for the primary virtualization layer (PR/SM)
>> as well as for secondary layers (z/VM and KVM).
>> ---
>>   src/shared/virt.c | 24 ++++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>> 
>> diff --git a/src/shared/virt.c b/src/shared/virt.c
>> index 774915f..af38b04 100644
>> --- a/src/shared/virt.c
>> +++ b/src/shared/virt.c
>> @@ -195,6 +195,30 @@ int detect_vm(const char **id) {
>>           } else
>>                   return r;
>> 
>> +#if defined(__s390x__)
>
> shouldn't __s390__ be checked instead? It covers both s390 and s390x
> and would make both 32 and 64 bit builds to include the same
> functionality.
>

Hm, s390 (32 bit) is quiet ancient.
Not sure if anyone would use such old systems with a pretty recent linux
version shipping systemd.
But if there are some use cases, of course we could do this.


Regards
Thomas