[systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

[Lennart Poettering]

On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johannbg at gmail.com) wrote:

> >>Seeing this list, why not name the variable Tier= ? Or
> >>DeploymentTier=, if just Tier is too specific?
> 
> This is specific for defining staging environment not their layer so
> can I simple get an ack nack on the deployment patch and those that
> also want to be able to define free string in there can just patch
> it.

Well, as I mentioned earlier, patch looks generally OK, but I am not OK
with the strict checking of the value. It sounds Ok to verify that it is
a single word, from a limited charset, but we are not going to become
the standardization institute for IT workflows.

Please remove the strict checking against the vocabulary, and repost!

(also needs man page updates...)

Lennart

-- 
Lennart Poettering, Red Hat