[systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

Lennart Poettering lennart at poettering.net
Thu Jul 10 16:37:26 PDT 2014


On Thu, 10.07.14 21:04, Jóhann B. Guðmundsson (johannbg at gmail.com) wrote:

> 
> 
> On 07/10/2014 08:44 PM, Lennart Poettering wrote:
> >On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johannbg at gmail.com) wrote:
> >
> >>>>Seeing this list, why not name the variable Tier= ? Or
> >>>>DeploymentTier=, if just Tier is too specific?
> >>This is specific for defining staging environment not their layer so
> >>can I simple get an ack nack on the deployment patch and those that
> >>also want to be able to define free string in there can just patch
> >>it.
> >Well, as I mentioned earlier, patch looks generally OK, but I am not OK
> >with the strict checking of the value. It sounds Ok to verify that it is
> >a single word, from a limited charset, but we are not going to become
> >the standardization institute for IT workflows.
> >
> >Please remove the strict checking against the vocabulary, and repost!
> >
> >(also needs man page updates...)
> 
> Then it wont solve the problem I was hoping to solve nor can I
> continue the other work I planned on based on these specific values
> so feel free to implement as you see fit or drop it altogether.

Hmm? Not follow here. You still can use the exact values you want,
however, the service will not check them against a whitelist, that's
all.

Anyway, if Jóhann lost interest, is anybody else interested to see this
being added? Tollef?

If so, I'd take Jóhann's patch, drop the checking and commit it...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list