[systemd-devel] [PATCH] readahead: use BTRFS_IOC_DEFRAG_RANGE

Timofey Titovets nefelim4ag at gmail.com
Sun Jul 20 23:16:17 PDT 2014


2014-07-21 5:21 GMT+03:00 Andrey Borzenkov <arvidjaar at gmail.com>:
> В Sun, 20 Jul 2014 22:27:20 +0300
> Timofey Titovets <nefelim4ag at gmail.com> пишет:
>
>> Just completed TODO:
>> * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG
>>
>
> It would be helpful to give explanation "why" for future reference.
>
>>
>> +/* TODO: Fix: wan't compile it it struct in ifndef HAVE_LINUX_BTRFS_H */
>
> Could you please check spelling here? I do not understand it, sorry.

/* TODO: Fix: won't compile if it struct included in ifdef HAVE_LINUX_BTRFS_H */
it is better, sorry

I have some problem with compile, if i insert
btrfs_ioctl_defrag_range_args in  #ifndef HAVE_LINUX_BTRFS_H like
btrfs_ioctl_vol_args. I can't compile, because ifndef not insert this
code.
and i place btrfs_ioctl_defrag_range_args without ifndef, and only
after this, it compile.
I can't understand why i have this problem, and as a result, do not
know how to fix it.

it acceptable for fix 'TODO' spelling and resend? Or may be, some one
know how fix my problem above with more acceptable solution?
-- 
Best regards,
Timofey.


More information about the systemd-devel mailing list