[systemd-devel] [PATCH] hostnamectl: correct IDs for remote hosts

[Mantas Mikulėnas]

On Sun, Jun 1, 2014 at 9:01 AM, Lennart Poettering
<lennart at poettering.net> wrote:
>
> On Sat, 31.05.14 18:21, Rico Sagner (sagner at b1-systems.de) wrote:
>
> Heya!
>
> I think that the two ids would probably be better exposed by PID 1
> istelf, instead of hostnamed. It's a bit difficult to come up with a
> rule which props should be exposed from hostnamed and which ones from
> PID1, but I think the rule should be something along the lines of "if
> it's more an automatically determined property than a user or vendor
> chosen one, and if PID 1 knows/caches it anyway then it belongs into PID
> 1"...
>
> So, could you please move the machine/boot IDs into PID 1 instead of
> hostnamed, next to where the Virtualization/Architecture properties are
> defined?

Out of curiosity, wouldn't the existing
org.freedesktop.DBus.Peer.GetMachineId() work here?

>
> Also, please use "ay" instead of "s" as type for the property (i.e. a
> byte-array of the 16 raw uuid bytes instead of an ascii-formatted
> string). This is how we encoded UUIDs so far as bus properties, see
> machined's machine uuid property (src/machine/machine-dbus.c) for example.
>
> Thanks!
>
> Lennart

-- 
Mantas Mikulėnas <grawity at gmail.com>