[systemd-devel] [PATCH] udev: check the return value from udev_enumerate_scan_devices

Thomas H.P. Andersen phomes at gmail.com
Wed Jun 4 14:40:43 PDT 2014


From: Thomas Hindoe Paaboel Andersen <phomes at gmail.com>

The return value from udev_enumerate_scan_devices was stored but
never used. I assume this was meant to be checked.
---
 src/udev/udevd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 0f3f3f0..f1daf49 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -780,6 +780,8 @@ static int synthesize_change(struct udev_device *dev) {
                         return r;
 
                 r = udev_enumerate_scan_devices(e);
+                if (r < 0)
+                        return r;
 
                 udev_list_entry_foreach(item, udev_enumerate_get_list_entry(e)) {
                         _cleanup_udev_device_unref_ struct udev_device *d = NULL;
-- 
1.9.3



More information about the systemd-devel mailing list