[systemd-devel] [PATCH] shared: fix searching for configs in alternate roots

[Lennart Poettering]

On Wed, 11.06.14 15:14, Michael Marineau (michael.marineau at coreos.com) wrote:

> Commit 12ed81d9 changed path_strv_canonicalize_absolute's behavior to
> return a directory list without the root prefix if one was given but did
> not update other users of the function to the new behavior. This broke
> the --root option in systemd-tmpfiles, a regression in v213.
> 
> To better reflect that path_strv_canonicalize_absolute does not return
> fully resolved paths any more as canonicalize may imply it is now simply
> called path_strv_cleanup.

Could you split out the renaming into a separate patch, please? Looks
good then. And for the other bits, I would prefer avoiding the
unnecessary strdup(), and simply use strappenda3() (see my other mail,
to Lukas). 

Lennart

-- 
Lennart Poettering, Red Hat