[systemd-devel] [PATCH 03/11] Ensure that ask-password-wall starts after getty.target

[Frederic Crozat]

Le vendredi 20 juin 2014 à 04:48 +0200, Zbigniew Jędrzejewski-Szmek a
écrit :
> On Fri, Jun 13, 2014 at 04:41:02PM +0200, Werner Fink wrote:
> > From: Frederic Crozat <fcrozat at suse.com>
> > 
> > ---
> >  units/systemd-ask-password-wall.service.in |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git units/systemd-ask-password-wall.service.in units/systemd-ask-password-wall.service.in
> > index 0eaa274..179b010 100644
> > --- units/systemd-ask-password-wall.service.in
> > +++ units/systemd-ask-password-wall.service.in
> > @@ -8,7 +8,8 @@
> >  [Unit]
> >  Description=Forward Password Requests to Wall
> >  Documentation=man:systemd-ask-password-console.service(8)
> > -After=systemd-user-sessions.service
> > +Wants=getty.target
> > +After=systemd-user-sessions.service getty.target
> 
> Why? It feels wrong to pull in getty.target from a password
> service. Password entry mechanisms and user login machanisms should be
> loosely coupled. One might e.g. use one manually configured getty to
> login into the system and e.g. enter passwords...

Hmm, the initial patch was ensuring this service was only started after
getty at tty1. From our changelog, it was later changed to the current
version with :
"- Make sure that systemd-ask-password-wall.service has a tty as
  it is not sure that a tty1 exists"

Werner, could you elaborate ?

-- 
Frederic Crozat
Project Manager Enterprise Desktop
SUSE