[systemd-devel] [PATCH] log: honour the kernel's quiet cmdline argument

[Ronny Chevalier]

2014-06-23 17:21 GMT+02:00 Ronny Chevalier <chevalier.ronny at gmail.com>:
> 2014-06-23 16:49 GMT+02:00 Lennart Poettering <lennart at poettering.net>:
>> On Tue, 10.06.14 19:17, Kay Sievers (kay at vrfy.org) wrote:
>>
>>>
>>> On Tue, Jun 3, 2014 at 7:44 PM, Ronny Chevalier
>>> <chevalier.ronny at gmail.com> wrote:
>>> > It was forgotten in b1e90ec515408aec2702522f6f68c4920b56375b
>>> >
>>> > See https://bugs.freedesktop.org/show_bug.cgi?id=79582
>>>
>>> Applied.
>>
>> I reverted this a while back btw, as this actually made all tools check
>> for "quiet", not just the two PID 1 binaries.
>>
>> While "debug" is something that should have an effect to all systemd
>> binaries, "quiet" should not. It should only turn off output off things
>> that end up on the boot screen. Hence it is wrong to check for "quiet"
>> at the same place as "debug".
> Yes, seems logic.
>
>>
>> Note that the log level and target is explicitly passed to the shutdown
>> binary via the command line, hence I don't really understand why the
>> patch was needed in the first place? Ronny, can you elaborate?
> It was needed because the quiet argument from the kernel cmdline was
> not being taken into account during shutdown, so multiple messages
> appeared, while the NEWS for v206[0] is mentioning that systemd
> honours the quiet argument also during shutdown.
>
> I did not check if there are messages appearing during shutdown now
> that you reverted the patch.
Ok so I checked and the quiet argument is honored.

>
> [0] http://cgit.freedesktop.org/systemd/systemd/tree/NEWS?id=v206#n77
>
> Ronny