[systemd-devel] [PATCH v4 1/2] Move handling of sysv initscripts to a generator

Alexey Shabalin a.shabalin at gmail.com
Tue Jun 24 10:56:22 PDT 2014


2014-06-07 3:01 GMT+04:00 Thomas H.P. Andersen <phomes at gmail.com>:
> On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering
> <lennart at poettering.net> wrote:
>> On Sat, 31.05.14 23:29, Thomas H.P. Andersen (phomes at gmail.com) wrote:
>>
>>> +
>>> +        if (s->sysv_start_priority > 0)
>>> +                fprintf(f, "SysVStartPriority=%d\n", s->sysv_start_priority);
>>> +
>>> +         if (s->pid_file)
>>> +                 fprintf(f, "PidFile=%s\n", s->pid_file);

rename PidFile to PIDFile, please.

>>> +
>>> +         fprintf(f, "ExecStart=%s start\n", s->path);
>>> +         fprintf(f, "ExecStop=%s stop\n", s->path);
>>
>> Looks good otherwise!
>
> Thanks. Pushed with fixes.
>
>> Thanks!
>>
>> Lennart

-- 
Alexey Shabalin


More information about the systemd-devel mailing list