[systemd-devel] [RFC 4/8] HACK0: allow meta information customizable

[Daniel Mack]

Hi,

On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
> My ftrace log shows that kdbus_meta_append(), is one of dominant functions
> in sending a message, while the other is kdbus_conn_queue_alloc().
> This patch adds an extra argument to kdbus_hello() utility function and
> allows us to explicitly specify meta information attached to a message
> for performance evaluation.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> ---
>  test/kdbus-util.c |   35 +++++++++++++++++++++--------------
>  test/kdbus-util.h |    2 ++
>  2 files changed, 23 insertions(+), 14 deletions(-)

Note that the kernel features of kdbus are defined by the kernel code,
not by the convenience wrappers for ioctl() that live in test/. As soon
as you start to implement your own code using kdbus features, I'd
strongly recommend you start over and implement your own low-level
functions. The ioctl API is actually simple enough to do this.


Same counts for patch #2 and #3 of this series.


Thanks,
Daniel