[systemd-devel] Potential major bug in 214

[Adam Williamson]

Hi, folks. I'm about 90% sure there's a fairly significant bug in the
systemd-sysv-generator that was introduced in 214. It's a bit
complicated, and the full details are at
https://bugs.freedesktop.org/show_bug.cgi?id=80537 . But the tl;dr
summary is this:

If there are any SysV initscripts in /etc/init.d that have:

# Provides: $network

or:

# Should-Start: $network

or:

# Required-Start: $network

they will wind up becoming dependencies of network-online.target, and so
on any system where network-online.target is required by anything else
(which is probably a lot of systems), they will be started at boot.
Regardless of whether they're actually enabled so far as SysV is
concerned. This has obvious potential unfortunate consequences...for
instance, on a system with a forgotten /etc/init.d/telnet
or /etc/init.d/vncserver or...you get the idea...lying around.

I poked quite far into the bug and I *think* I more or less understand
what's going on, but I wasn't able to come up with a sufficient fix for
it. If folks could treat the report with a bit of urgency at least until
it's established whether I'm correct or misunderstanding something,
that'd be great. thanks!
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net