[systemd-devel] [RFC 1/8] (bugfix) undefined member, len, in struct kdbus_pool_slice

AKASHI Takahiro takahiro.akashi at linaro.org
Thu Jun 26 03:00:11 PDT 2014


Hi Daniel,

On 06/25/2014 06:49 PM, Daniel Mack wrote:
> On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
>> ---
>>   pool.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/pool.c b/pool.c
>> index d896d9b..4267c54 100644
>> --- a/pool.c
>> +++ b/pool.c
>> @@ -623,7 +623,7 @@ void kdbus_pool_slice_flush(const struct kdbus_pool_slice *slice)
>>   #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE == 1
>>   	struct address_space *mapping = slice->pool->f->f_mapping;
>>   	pgoff_t first = slice->off >> PAGE_CACHE_SHIFT;
>> -	pgoff_t last = (slice->off + slice->len +
>> +	pgoff_t last = (slice->off + slice->size +
>
> Hmm, strange. This bug has been fixed upstream in May already. Which
> tree are you working against?

My current study is based on the snapshot as of Apr. 24. Never mind.
Next time I will rebase the patch, if I have a chance, to the latest.

# I found another bug in test/kdbus-util.c

Thanks,
-Takahiro AKASHI

> Daniel
>


More information about the systemd-devel mailing list