[systemd-devel] [PATCH] Add support for DHCP static route options in networkd

Eugene Yakubovich eyakubovich at gmail.com
Thu Jun 26 10:37:32 PDT 2014


> On Wed, 25.06.14 18:03, Eugene Yakubovich (eyakubovich at gmail.com) wrote:
>
> The patch is line-broken....
I resent it last night with [PATCH resent] in the subject. Is that one
also line broken? It was resent with git send-email so should be ok.

> Just one quick question without looking into much detail into the patch:
> why add a new UseRoutes= switch for this? Why shouldn't this be done
> always when DHCP is enabled?
>

Definitely something that I would like feedback on. I mostly followed
the lead for UseMTU switch -- that is use a switch for less common
DHCP options. Maybe it's better to have that switch default to true
(vs false as now) but I do think having an ability to opt out of DHCP
server specified routes is a good idea. Since the user can specify
options in [Routes] section, he might be doing something custom and
not want routes specified by the network admin (via DHCP).


More information about the systemd-devel mailing list