[systemd-devel] [PATCH] timer: name the stamp file consistently

Lennart Poettering lennart at poettering.net
Fri Jun 27 10:49:58 PDT 2014


On Fri, 27.06.14 16:19, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> > > >                          _cleanup_free_ char *h = NULL;
> > > 
> > > Yeah, consistency is good, and this fixes a problem where one defines
> > > an XDG_DATA_HOME which points at the same place as the default and
> > > then the timers fire prematurely.
> > > 
> > > Nevertheless, after this patch some timers stored in XDG_DATA_HOME
> > > will fire prematurely too. I applied the patch because I think that
> > 
> > "Will fire prematurely, too"? What do you mean?
> If we lose the timestamp, than systemd will think it has not fired
> yet, so will fire it immediately after the reboot, i.e. sooner than it
> otherwise would have.

Hmm, are you saying the current logic is "no stamp file, trigger
immediately"? And you say it should be "no stamp file, pretend there was
one with the current time"?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list