[systemd-devel] [PATCH] unit: make unit can start without instance

[Lennart Poettering]

On Wed, 28.05.14 00:39, WaLyong Cho (walyong.cho at samsung.com) wrote:

Sorry for the late response!

> I'm not sure this could be patch for below TODO.
> 
> * enabling an instance unit creates a pointless link, and
>   the unit will be started with getty at getty.service:
>     $ systemctl enable getty at .service
>     ln -s '/usr/lib/systemd/system/getty at .service'
>     '/etc/systemd/system/getty.target.wants/getty at .service'

This specific issue is fixed now in git, with a different patch.

> If can be, when this can be used?
> And I couldn't avoid one of strdup in manager_load_unit_prepare(). And
> I wasn't able to make a suit name better than instanceless.

I am not entirely sure what your patch is supposed to do? If it is still
useful after the fix in git, can you elaborate, please?

Thanks!

> 
> WaLyong Cho (1):
>   unit: make unit can start without instance
> 
>  src/core/manager.c     | 10 ++++++----
>  src/shared/unit-name.c | 12 ++++++++++++
>  src/shared/unit-name.h |  1 +
>  3 files changed, 19 insertions(+), 4 deletions(-)
> 


Lennart

-- 
Lennart Poettering, Red Hat