[systemd-devel] [PATCH] fstab-generator: do not check btrfs and xfs

[Tom Gundersen]

On Sun, Jun 29, 2014 at 11:31 PM, Stefan G. Weichinger <lists at xunil.at> wrote:
> Am 29.06.2014 23:24, schrieb Lennart Poettering:
>> On Sun, 29.06.14 21:51, Kai Krakow (hurikhan77 at gmail.com) wrote:
>>> # /sbin/fsck.btrfs /dev/sdb3
>>> If you wish to check the consistency of a BTRFS filesystem or
>>> repair a damaged filesystem, see btrfs(8) subcommand 'check'.
>>
>> Is this an upstream thing? Or is that specific to your distro?
>>
>> It sounds really wrong to me to do something like what they are
>> doing. Either they provide a real implementation, or they don't supply
>> an implementation. Either is fine. But if they supply an implementation
>> that justs prints a warning will simply mean that various tools
>> (including systemd) will invoke it, for no reason.
>
> This is how gentoo currently implements things.
> So the devs there should link it to /bin/true ?
> We could open a bug for that at bugs.gentoo.org ...

IMHO both xfs and btrfs should just not ship a fsck helper at all, not
even as a symlink. This workaround made sense at some point, but now I
believe both systemd _and_ fsck itself can deal gracefully with a
missing fsck helper.

-t