[systemd-devel] [systemd-commits] 2 commits - src/libsystemd src/network

[Tom Gundersen]

On Sat, Mar 8, 2014 at 6:23 PM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Fri, Mar 07, 2014 at 04:13:06PM -0800, Tom Gundersen wrote:
>>  src/libsystemd/sd-rtnl/rtnl-internal.h |    2 +-
>>  src/network/networkd-link.c            |    6 ++----
>>  2 files changed, 3 insertions(+), 5 deletions(-)
>>
>> New commits:
>> commit 76800848f281c3705c9364fd3e888153d94aaf34
>> Author: Tom Gundersen <teg at jklm.no>
>> Date:   Sat Mar 8 01:08:30 2014 +0100
>>
>>     networkd: link - degrade failed UP to warning
>>
>>     Something else may still bring the link up, so don't enter failed state prematurely.
>>
>> diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
>> index 785e8d5..9fb8d9f 100644
>> --- a/src/network/networkd-link.c
>> +++ b/src/network/networkd-link.c
>> @@ -1056,15 +1056,13 @@ static int link_up_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userdata) {
>>                  return 1;
>>
>>          r = sd_rtnl_message_get_errno(m);
>> -        if (r < 0) {
>> -                log_struct_link(LOG_ERR, link,
>> +        if (r < 0)
>> +                log_struct_link(LOG_WARNING, link,
>>                                  "MESSAGE=%s: could not bring up interface: %s",
>>                                  link->ifname, strerror(-r),
>>                                  "ERRNO=%d", -r,
>>                                  NULL);
>> -                link_enter_failed(link);
>>                  return 1;
>> -        }
> Hi Tom,
>
> link_update_flags is unreachable. I pushed an update, please check
> if it looks ok.

Looks good. Thanks!

Cheers,

Tom