[systemd-devel] [PATCH] systemd-run: extend bash completion

[Zbigniew Jędrzejewski-Szmek]

On Tue, Mar 11, 2014 at 08:05:48AM +0100, Thomas H.P. Andersen wrote:
> On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering
> <lennart at poettering.net> wrote:
> > On Wed, 05.03.14 23:48, Thomas H.P. Andersen (phomes at gmail.com) wrote:
> >
> >> From: Thomas Hindoe Paaboel Andersen <phomes at gmail.com>
> >>
> >> --system
> >> -H --host
> >> -M --machine
> >> --service-type (options: simple forking oneshot dbus notify idle)
> >> --uid
> >> --gid
> >> --nice
> >> --setenv
> >> -p --property (options read from bus_append_unit_property_assignment)
> >
> > Looks good as far as I grok the completion things. Zbigniew, you know
> > this better than I do, can you OK this?
> 
> I was mostly looking for a verification that the list of options make
> are correct:
> 
> --service-type:
> simple forking oneshot dbus notify idle
Yes.

> --property:
> CPUAccounting MemoryAccounting BlockIOAccounting SendSIGHUP
> SendSIGKILL MemoryLimit CPUShares BlockIOWeight User Group
> DevicePolicy KillMode DeviceAllow BlockIOReadBandwidth
> BlockIOWriteBandwidth BlockIODeviceWeight Nice Environment KillSignal

Isn't this missing the rlimit stuff (LimitCPU, LimitFSIZE, LimitDATA,
LimitSTACK, LimitCORE, LimitRSS, LimitNOFILE, LimitAS, LimitNPROC,
LimitMEMLOCK, LimitLOCKS, LimitSIGPENDING LimitMSGQUEUE, LimitNICE,
LimitRTPRIO, LimitRTTIME)? It would be great to generate this list
programatically, but I don't see an immediate way.

> Some of the properties take e.g. a boolean value and we could go on to
> suggest an on/off value but I did not go that far.
Yeah, I think one has to read what the available options mean anyway,
and most values cannot be completed anyway, so completion for the
*values* is less important.

Zbyszek