[systemd-devel] [PATCH 2/2] backlight: Avoid restoring brightness to an unreadably dim level

[Lennart Poettering]

On Wed, 12.03.14 08:47, josh at joshtriplett.org (josh at joshtriplett.org) wrote:

> 
> On Wed, Mar 12, 2014 at 04:44:55PM +0100, Lennart Poettering wrote:
> > On Tue, 11.03.14 21:16, Josh Triplett (josh at joshtriplett.org) wrote:
> > 
> > > Some systems turn the backlight all the way off at the lowest levels.
> > > Clamp saved brightness to at least 1 or 5% of max_brightness.  This
> > > avoids preserving an unreadably dim screen, which would otherwise force
> > > the user to disable state restoration.
> > 
> > Applied, made a minor change though: I downgrade the warning message to
> > debug, since this isn' really something to warn about..
> 
> If you mean the message "Saved brightness %s too low; increasing to %s",
> I think that one needs to be visible to users.  It shouldn't normally
> happen, and if it does, the user should know why the saved brightness
> wasn't preserved.

I am pretty sure this would be shown on common setups, since for many
laptops brightness 0 might actually be something other than total
black. And I am simply not intersted in getting complaints about this
warning being shown at boot... This really is something that should be
discoverable if you debug things, but otherwise be hidden.

Lennart

-- 
Lennart Poettering, Red Hat