[systemd-devel] [PATCH] service: don't create extra cgroup for control process when reloading SysV service

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Mar 12 10:34:11 PDT 2014


On Wed, 2014-03-12 at 16:51 +0100, Lennart Poettering wrote:
> On Mon, 10.03.14 15:25, Lukas Nykryn (lnykryn at redhat.com) wrote:
> 
> > Unfortunately common practice in initscripts is to have reload as an
> > alias for restart (https://fedoraproject.org/wiki/Packaging:SysVInitScript).
> > In that case the newly started process will be killed immediately after
> > the reload process ends and its cgroup is destroyed.


> I am not sure I grok why this all would be a problem at all, given that
> on Fedora/RHEL we redirect those verbs to systemctl anyway, and
> systemctl handles reload/restart on its own anyway... What am I missing?

But systemctl supports using the reload functionality in init scripts,
so that doesn't really make a difference. As I understood the problem
description, this is what happens: someone runs "systemctl reload
foo.service" for a broken sysv script, systemd sees that the script
seems to support a "reload" argument and runs "/etc/init.d/foo reload"
in a temporary cgroup, but the broken script stops the running service
and starts a new one in the temporary cgroup.




More information about the systemd-devel mailing list