[systemd-devel] [PATCH 4/4] libsystemd-network: Add Init-Reboot support

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Mon Mar 17 07:08:37 PDT 2014


On Mon, Mar 17, 2014 at 03:47:34PM +0200, Patrik Flykt wrote:
> On Sat, 2014-03-15 at 04:02 +0100, Zbigniew Jędrzejewski-Szmek wrote:
> > This means that I can complain about spelling :) There's no such word
> > as "broadcasted". Past tense and adjective are "broadcast".
> 
> Yes :-) Spelling fixed.
> 
> > > -                        if (client->state == DHCP_STATE_REQUESTING)
> > > +                        if (client->state == DHCP_STATE_REQUESTING ||
> > > +                            client->state == DHCP_STATE_REBOOTING)
> > Using IN_SET(client->state, DHCP_STATE_REQUESTING,  DHCP_STATE_REBOOTING)
> > seems to be visually less cluttered.
> 
> Updated to IN_SET.
> 
> If there are no more comments, I can probably go ahead and apply these
> four patches?
Yes, they look fine.

Zbyszek



More information about the systemd-devel mailing list