[systemd-devel] systemd-networkd bridge with DHCP not working

Tom Gundersen teg at jklm.no
Fri Mar 21 11:02:40 PDT 2014


On Fri, Mar 21, 2014 at 9:57 AM, Patrik Flykt
<Patrik.Flykt at linux.intel.com> wrote:
> On Thu, 2014-03-20 at 20:29 +0100, Tom Gundersen wrote:
>> My proposal is:
>>
>> Whenever the MAC address changes under us networkd calls
>> sd_{dhcp_client,ipv4ll}_set_mac(), and it is the libs' responsibility
>> to then do the right thing.
>>
>> Currently the libs don't support this and will fail with EBUSY, so I
>> suggest we change that into letting them restart themselves
>> internally, and send out notifications that the lease has been lost
>> (so networkd will drop the addresses correctly, if it has any
>> assigned).
>>
>> Umut, Patrik, what do you think?
>
> Yes, let's fix the library to take care of a changing MAC address.

I now made this change in git for both libraries.

It seems to me that the kernel could behave better when enslaving
devices to a bridge (i.e., bring down the bridge before changing its
mac address, rather than first changing the mac address and then bring
the bridge down/up), but this should be fairly robust from our side,
regardless of what the kernel does.

Cheers,

Tom


More information about the systemd-devel mailing list