[systemd-devel] [PATCH] core: make parsing of chkconfig headers conditional

[Michael Biebl]

2014-03-24 17:36 GMT+01:00 Lennart Poettering <lennart at poettering.net>:
> On Mon, 24.03.14 17:25, Michael Biebl (mbiebl at gmail.com) wrote:
>
>> 2014-03-24 17:21 GMT+01:00 Lennart Poettering <lennart at poettering.net>:
>> > Well, but we are a lot more dependent on correct headers than other
>> > parsers anyway... For example, the LSB deps have traditionally been much
>> > less accurately followed than they are now...
>> >
>> > I mean, we don't claim compatibility with scripts with broken headers,
>> > anyway...
>>
>> Sorry, but I don't get your point.
>>
>> If I disable chkconfig support, then I don't want the chkconfig
>> headers parsed. Isn't that quite obvious?
>
> Well, it's two different things:
>
> a) defer to /sbin/chkconfig if "systemctl enable" is used on a sysv
>    service.
>
> b) take into account any information included in the sysv header that
>    exists.
>
> Turning off chkconfig support does a), not b). And I'd really prefer if
> sysv scripts would behave the same way on all systemd installations... I
> mean that's what we try to do after all, provide a unified interface
> for developers...

Since Debian doesn't have chkconfig, sysv init script already behave
differently when it comes to a), so the point about having sysv init
scripts behave the same on all systemd installations is moot.

It really doesn't make sense to parse the chkconfig headers on distros
which don't support that interface. The result is worse then not
parsing it at all.
I don't mint terribly if you want to keep the # description: parsing
in, but the # chkconfig: and # pidfile: parsing should not be done on
distros where does headers never have been used/tested.



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?