[systemd-devel] [PATCH 4/4] Add binary password agent protocol

David Härdeman david at hardeman.nu
Tue Mar 25 02:37:40 PDT 2014


On Tue, Mar 25, 2014 at 01:58:27AM +0100, Lennart Poettering wrote:
>On Tue, 04.02.14 00:57, David Härdeman (david at hardeman.nu) wrote:
>
>Sorry for the later review!
>
>> Add binary string handling functions and extend the password agent
>> protocol to support binary strings (using "=" as a string prefix
>> instead of "+").
>
>Hmm, I wished there was a different way to implement this, rather than
>having to introduce bstrv... But I see no other way, I fear.. :-(
>
>(Well, we could always just pass an escaped string around, never the
>binary data, and then only convert to binary data only as last step. But
>I figure that would just lying to ourselves...)
>
>I figure this has to do then. Could you please rebase to current git?

This one will take a bit longer. First I wanted to see that you agree
with the direction of the patch. Since you do, I'll spend the time to
write up some test cases before I resubmit this patch.

-- 
David Härdeman


More information about the systemd-devel mailing list