[systemd-devel] [ANNOUNCE] systemd 212

[Kay Sievers]

On Wed, Mar 26, 2014 at 2:40 AM, Kay Sievers <kay at vrfy.org> wrote:
> On Wed, Mar 26, 2014 at 2:37 AM, Stephan Raue <mailinglists at openelec.tv> wrote:
>> Am 26.03.2014 02:16, schrieb Kay Sievers:
>>
>>> On Wed, Mar 26, 2014 at 1:45 AM, Stephan Raue <mailinglists at openelec.tv>
>>> wrote:
>>>>
>>>> systemd-212 breaks if we run autoreconf before configuring and building
>>>> with:
>>>>
>>>> autoreconf: running:
>>>>
>>>> /home/stephan/projects/openelec-master/build.OpenELEC-Generic.x86_64-devel/toolchain/bin/automake
>>>> --add-missing --copy --force-missing
>>>> Makefile.am:36: warning: user target '.PRECIOUS' defined here ...
>>>>
>>>> /home/stephan/projects/openelec-master/build.OpenELEC-Generic.x86_64-devel/toolchain/share/automake-1.14/am/configure.am:
>>>> ... overrides Automake target '.PRECIOUS' defined here
>>>> docs/gtk-doc.make:270: error: HAVE_GTK_DOC does not appear in
>>>> AM_CONDITIONAL
>>>> docs/gudev/Makefile.am:98:   'docs/gtk-doc.make' included from here
>>>> docs/gtk-doc.make:270: error: HAVE_GTK_DOC does not appear in
>>>> AM_CONDITIONAL
>>>> docs/libudev/Makefile.am:92:   'docs/gtk-doc.make' included from here
>>>> autoreconf:
>>>>
>>>> /home/stephan/projects/openelec-master/build.OpenELEC-Generic.x86_64-devel/toolchain/bin/automake
>>>> failed with exit status: 1
>>>
>>> Have you tried passing --disable-gtk-doc to configure? Check ./configure
>>> --help.
>>
>> yes we are building with --disable-gtk-doc
>> see:
>> https://github.com/OpenELEC/OpenELEC.tv/blob/master/packages/sysutils/systemd/package.mk#L41
>>
>> but the problem is not at configure time, we do a autoreconf before
>> configuring for every package
>>
>>>> even if there is no change in docs/gtk-doc.make between 211 and 212 the
>>>> files differs in the tarball. using this patch:
>>>>
>>>> https://github.com/OpenELEC/OpenELEC.tv/blob/ae1cb224141c8e7b179619285333fc0dc741b0ac/packages/sysutils/systemd/patches/systemd-212-GTK_DOC.patch
>>>
>>> This file in not in git, and cannot be patched upstream, it is added
>>> by gtk-doc itself.
>>
>> yes but its part of the tarball, and it seems to be wrong (HAVE_GTK_DOC vs.
>> ENABLE_GTK_DOC) - at least if we compare the file from 211 with the one from
>> 212.
>
> It might be a change in upstream gtk-doc, I don't know, I built the
> tarball with:
>   gtk-doc-1.20-1.fc21.noarch
> installed, maybe something has change there, we need to find out ...

Hmm, *seems* to work fine here with the tarball and without gtk-doc installed:

$ autoreconf -v
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I m4 ${ACLOCAL_FLAGS}
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not running libtoolize: --install not given
autoreconf: running: /usr/bin/autoconf
autoreconf: running: /usr/bin/autoheader
autoreconf: running: automake --no-force
Makefile.am:36: warning: user target '.PRECIOUS' defined here ...
/usr/share/automake-1.14/am/configure.am: ... overrides Automake
target '.PRECIOUS' defined here
autoreconf: Leaving directory `.'

$ ./configure
...
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gtk-doc... no
configure: WARNING:
  You will not be able to create source packages with 'make dist'
  because gtk-doc >= 1.18 is not found.
checking for gtkdoc-check... no
checking for gtkdoc-check... no
checking for gtkdoc-rebase... no
checking for gtkdoc-mkpdf... no
checking whether to build gtk-doc documentation... no
checking for GTKDOC_DEPS... yes
checking for gobject-introspection... yes
checking for strings... strings
checking for gperf... gperf
checking if gcc -std=gnu99 supports flag -pipe in envvar CFLAGS... yes
...

Kay