[systemd-devel] Inconsistent device naming for dual-port or multi-port network devices

[Robert Milasan]

Hello, seems that on some systems (in our cases s390x) a dual
port network device, is named ens11 and ens11d1 which doesn't exactly
looks normal (not sure if this in on purpose or not)

udevadm info -a -p /sys/class/net/ens11 | grep dev_id
    ATTR{dev_id}=="0x0"
udevadm info -a -p /sys/class/net/ens11d1 | grep dev_id
    ATTR{dev_id}=="0x1"

Seems that in src/udev/udev-builtin-net_id.c:201 we don't use dev_id,
if dev_id = 0.

Again, checking the idea in the header of udev-builtin-net_id.c, the
logic should be:

en (ethernet), s <slot>, f <function>, d <dev_id>, but is not specified
that dev_id is not use if dev_id = 0.

The logic should be ens11d0 and ens11d1, at least according to how it
is explained.

I've attached the patch which fixes this issue, if this is not really a
bug, then ignore the mail :)


-- 
Robert Milasan

L3 Support Engineer
SUSE Linux (http://www.suse.com)
email: rmilasan at suse.com
GPG fingerprint: B6FE F4A8 0FA3 3040 3402  6FE7 2F64 167C 1909 6D1A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-dev_id-for-network-devices-even-if-dev_id-equals-zero.patch
Type: text/x-patch
Size: 989 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20140505/113a399f/attachment.bin>