[systemd-devel] [PATCH] connection: fix kernel oop when conn_name not set

[Kay Sievers]

On Mon, May 12, 2014 at 3:24 PM, Jacek Janczyk <j.janczyk at samsung.com> wrote:
> kernel oops when connection name (kdbus_conn.name) not set via HELLO
> message but requested with attach flags KDBUS_ATTACH_CONN_NAME.

Hmm, here does it crash? Seems the code that attaches the string
checks for the string being set:
  if ((mask & KDBUS_ATTACH_CONN_NAME) && conn && conn->name)

> As conn.name is defined as "for debug purposes" I find it more
> convenient to return generic name than to strip the field from
> requested metadata or raise an error on request.

I prefer if we just return nothing when we miss non-essential data.
The kernel and its magic strings, which which can also just be
supplied by users like the " (deleted)" for file names, are generally
not a good idea.

Kay