[systemd-devel] [PATCH] readahead: ARM: fix rotational media detection for MMC

Lennart Poettering lennart at poettering.net
Tue May 13 05:19:06 PDT 2014


On Tue, 13.05.14 13:49, alison_chaiken at mentor.com (alison_chaiken at mentor.com) wrote:

> From: Alison Chaiken <alison_chaiken at mentor.com>
> 
> The ARM runtime reports the major device type associated with
> /proc/self/mountinfo as MMC_BLOCK_MAJOR, causing on_ssd() in
> readahead-common.c to return false.   on_ssd() should return true, as
> MMC like SSD is not rotational.

Not following here. fs_on_ssd() will actually check for the high-level
ID_SSD property, as well as the "queue/rotational" sysfs attribute for
the block device.

Are you saying that on you machine queue/rotational is set to 1 for
MMCs? If so, this appears to be the more appropriate thing to fix?

Moreover, why is this supposedly ARM specific?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list