[systemd-devel] [PATCH] gudev: avoid using export-symbols-regex

[Cristian Rodríguez]

El mar 20 may 2014 13:25:52 CLT, Kay Sievers escribió:
> On Wed, Apr 23, 2014 at 11:43 AM, Cristian Rodríguez
> <crrodriguez at opensuse.org> wrote:
>> There is no need for this hackery, just hide the internal
>> functions using glib 's  G_GNUC_INTERNAL macro.
>
> Hmm, why is that a hack?
>
> Explicitly exporting functions with a well-defined prefix sounds more
> robust than exporting everything that isn't explicitly hidden, or do I
> miss something?

I came across this while trying to build gudev with gcc 4.9, it turns 
out there seems to be a bug in libtool that causes it to generate 
improper
symbol scripts when LTO is enabled.. (it calls nm, when it should call 
gcc wrapper gcc-nm-..)  Therefore I attempted to simply get rid of it by
using the compiler facility to hide what needs to be hidden.

By now I figured the root cause however.


--
Cristian
"I don't know the key to success, but the key to failure is trying to 
please everybody."