[systemd-devel] On the recent commit "conf-parser: never consider it an error"

[Alexander E. Patrakov]

Hello.

The code touched by commit 9f43a07f1 is possibly buggy. Here is why I 
think so.

The new lines added are:

log_full(errno == ENOENT ? LOG_DEBUG : LOG_ERR, "Failed to open 
configuration file '%s': %m", filename);

return errno == ENOENT ? 0 : -errno;

However, I don't understand why errno in the second line is the original 
errno. I.e. why log_full() can't clobber the errno with some other error 
that happens while logging.

-- 
Alexander E. Patrakov