[systemd-devel] [PATCH] Fix several small typos

Jonathan Boulle jonathanboulle at gmail.com
Fri May 23 11:56:42 PDT 2014


Fix some small comment/log typos
--

 CODING_STYLE                       | 2 +-
 src/core/unit.c                    | 6 +++---
 src/network/networkd-wait-online.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/CODING_STYLE b/CODING_STYLE
index 996897b..4ec5923 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -16,7 +16,7 @@
   half-initialized objects, too

 - Error codes are returned as negative Exxx. i.e. return -EINVAL. There
-  are some exceptions: for constructors its is OK to return NULL on
+  are some exceptions: for constructors it is OK to return NULL on
   OOM. For lookup functions NULL is fine too for "not found".

   Be strict with this. When you write a function that can fail due to
diff --git a/src/core/unit.c b/src/core/unit.c
index 3f862aa..6e40bc6 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -1574,7 +1574,7 @@ void unit_notify(Unit *u, UnitActiveState os,
UnitActiveState ns, bool reload_su

         /* Note that this is called for all low-level state changes,
          * even if they might map to the same high-level
-         * UnitActiveState! That means that ns == os is OK an expected
+         * UnitActiveState! That means that ns == os is an expected
          * behavior here. For example: if a mount point is remounted
          * this function will be called too! */

@@ -1597,7 +1597,7 @@ void unit_notify(Unit *u, UnitActiveState os,
UnitActiveState ns, bool reload_su
                         u->active_exit_timestamp = ts;
         }

-        /* Keep track of failed of units */
+        /* Keep track of failed units */
         if (ns == UNIT_FAILED && os != UNIT_FAILED)
                 set_put(u->manager->failed_units, u);
         else if (os == UNIT_FAILED && ns != UNIT_FAILED)
@@ -1722,7 +1722,7 @@ void unit_notify(Unit *u, UnitActiveState os,
UnitActiveState ns, bool reload_su
         if (UNIT_IS_ACTIVE_OR_RELOADING(ns)) {

                 if (unit_has_name(u, SPECIAL_DBUS_SERVICE))
-                        /* The bus just might have become available,
+                        /* The bus might have just become available,
                          * hence try to connect to it, if we aren't
                          * yet connected. */
                         bus_init(m, true);
diff --git a/src/network/networkd-wait-online.c
b/src/network/networkd-wait-online.c
index 0b8e35d..c6038c6 100644
--- a/src/network/networkd-wait-online.c
+++ b/src/network/networkd-wait-online.c
@@ -124,7 +124,7 @@ static bool all_configured(Manager *m) {

                 r = sd_rtnl_message_new_link(m->rtnl, &message,
RTM_GETLINK, 0);
                 if (r < 0) {
-                        log_warning("colud not create GETLINK
message: %s", strerror(-r));
+                        log_warning("could not create GETLINK
message: %s", strerror(-r));
                         return false;
                 }


More information about the systemd-devel mailing list