[systemd-devel] [PATCH] Drop the udev firmware loader

[Cristian Rodríguez]

El 29/05/14 21:54, Greg KH escribió:
> On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote:
>> As discussed ad-nauseum previously, it is the kernel's task
>> to load firmware, not udev's.
>> ---
>>  Makefile.am             |  8 --------
>>  configure.ac            | 20 --------------------
>>  src/udev/udev-builtin.c |  3 ---
>>  src/udev/udev.h         |  6 ------
>>  src/udev/udevd.c        | 13 -------------
>>  5 files changed, 50 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 50e7560..2965966 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -2788,14 +2788,6 @@ libudev_core_la_CPPFLAGS = \
>>  	$(AM_CPPFLAGS) \
>>  	-DFIRMWARE_PATH="$(FIRMWARE_PATH)"
>>  
>> -if ENABLE_FIRMWARE
>> -libudev_core_la_SOURCES += \
>> -	src/udev/udev-builtin-firmware.c
> 
> You forgot to delete this file as well, any reason why?

Oh, right. I could submit a second patch that does just that though
(plus removing the item from the TODO list)


-- 
Cristian
"I don't know the key to success, but the key to failure is trying to
please everybody."