[systemd-devel] [PATCH] rules: rerun vconsole-setup when switching from vgacon to fbcon

[David Herrmann]

Hi

On Wed, Nov 5, 2014 at 4:11 PM, Ray Strode <halfline at gmail.com> wrote:
> Hi,
>
> On Wed, Nov 5, 2014 at 9:53 AM, David Herrmann <dh.herrmann at gmail.com> wrote:
>> I had that change locally, but didn't push it because vconsole is
>> optional. Thus, this rule must be optional, too. I'm now digging into
>> autoconf+m4 to see how to do this... but I'm getting nowhere so far...
>
> Well you could:
>
> 1) rename 99-systemd.rules.in to 99-systemd.rules.in.in and then add
> it to AC_CONFIG_FILES in configure.ac and add substitution variable to
> 99-systemd.rules.in.in that expands to the empty string when
> ENABLE_VCONSOLE isn't set and the udev rule when it is set.  I don't
> like that though, it would mean separating the udev rule from the
> file.
>
> 2) Alternatively, you could leave 99-systemd.rules.in as is and hack
> SED_PROCESS stuff in the makefile to remove the line if
> ENABLE_VCONSOLE isn't set. I don't like this either, it's ugly.

Ewwww, this does indeed all sound ugly.

>> So if you have no idea how to make that rule be generated only if
>> ENABLE_VCONSOLE is set by configure, then we probably should take my
>> patch below.
> Your patch seems far better than the options above, but I think it
> needs a dracut patch to make sure the new rules file gets in the
> initrd too, or it won't work.

I will push the patch to systemd and let Harald know. I'm not really
familiar with dracut..

Thanks
David