[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

Lennart Poettering lennart at poettering.net
Thu Nov 6 17:44:26 PST 2014


On Thu, 06.11.14 10:49, Jan Synacek (jsynacek at redhat.com) wrote:

> I think that this patch might be a bit ineffective, as it calls
> unit_file_load() again just to get an InstallContext. I wasn't sure
> how to get Also= targets in any other way.
> 
> If such change makes sense, this patch should probably be considered a
> preview rather than something to be committed right away.

Hmm, wouldn't it be nicer to introduce a new UnitFileState enum value
for this?

Maybe UNIT_FILE_ALSO or so? 

I am not sure I like the idea of implicitly following the Also= setting here, due
to the awkwarndess if multiple units are listed and how to map exotic
states of that other unit back to ours...

Would that make sense?

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list